[ 
https://issues.apache.org/jira/browse/HDFS-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057950#comment-13057950
 ] 

Eli Collins commented on HDFS-2110:
-----------------------------------

Hey Uma,

Thanks for taking a look!  I updated the patch for HDFS-1753 to address 
sendPartialData.

I made the new copyBytes method consistent with the others. How about a new 
jira to make IOUtils#copy* methods close streams according to the discussion in 
MAPREDUCE-2243?

Thanks,
Eli



> Some StreamFile and ByteRangeInputStream cleanup
> ------------------------------------------------
>
>                 Key: HDFS-2110
>                 URL: https://issues.apache.org/jira/browse/HDFS-2110
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: hdfs-2110-1.patch, hdfs-2110-2.patch, hdfs-2110-3.patch
>
>
> StreamFile#sendPartialData can be cleaned up, has some System.out.printlns, 
> no javadoc, and the byte copying method should be pulled out to IOUtils. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to