[
https://issues.apache.org/jira/browse/HDFS-13395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426719#comment-16426719
]
Elek, Marton commented on HDFS-13395:
-------------------------------------
Thank you very much [~nandakumar131] to work in this. Overall it looks good to
me. Originally I was afraid it will be to complex for the end-users but I don't
know any better solution other than this patch. And checking this patch it's
even more simpler than the current solution as we don't relay on the order of
the two datanode service plugin.
I have some suggestions (some of them just realy small ones to make it safer to
use the two different plugin level):
1. First of all: as I see (if I didn't miss something) the
DataNodeServicePlugin is not used any more. Can we just remove it (this is the
biggest selling point why I really like this patch)?
2. There is a typo in the hadoop-dist/src/main/compose/ozone/docker-config
(OZONE-SITE.XML_dfs.datanode.plugins=org.apache.hadoop.ozone.web.OzoneHdslDatanodeService).
It should be hdsl.datanode.plugins, I guess.
3. Please also update the docker-compose file in the
hadoop-ozone/acceptance-test project. (After that you can run the tests with
mvn integration-test -P ozone-acceptance-test)
4. I would add additional check to the OzoneHdslDatanodeService.start() to
make sure it's not started as a datanode level service plugin.
{code}
if (service instanceof HdslDatanodeService){
...
} else {
throw new ...Exception(getClass()+" should be activated as a hdsl plugin.
Please use hdsl.datanode.plugins configuration key.")
}
{code}
Or similar thing with PreconditionCheck....
5. The first users will enable the OzoneRest plugin all the time. I would
consider to make it as a default value for hdsl.datanode.plugins to increase
the usability.
Except this small comments I am really happy with this patch. I tested it with
the acceptance test project (as wrote before) and everything worked well
(except freon). I am not sure if the freon failure is related or not (class not
found). Could be still a wrong class-path setting.
> Ozone: Plugins support in HDSL Datanode Service
> -----------------------------------------------
>
> Key: HDFS-13395
> URL: https://issues.apache.org/jira/browse/HDFS-13395
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Nanda kumar
> Assignee: Nanda kumar
> Priority: Major
> Attachments: HDFS-13395-HDFS-7240.000.patch
>
>
> As part of Datanode, we start {{HdslDatanodeService}} if {{ozone}} is
> enabled. We need provision to load plugins like {{Ozone Rest Service}} as
> part of {{HdslDatanodeService}} start.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
