[
https://issues.apache.org/jira/browse/HDFS-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057975#comment-13057975
]
Hadoop QA commented on HDFS-1753:
---------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12484799/HDFS-1753.3.patch
against trunk revision 1141416.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/869//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/869//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/869//console
This message is automatically generated.
> Resource Leak in org.apache.hadoop.hdfs.server.namenode.StreamFile
> ------------------------------------------------------------------
>
> Key: HDFS-1753
> URL: https://issues.apache.org/jira/browse/HDFS-1753
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HDFS-1753.1.patch, HDFS-1753.2.patch, HDFS-1753.3.patch,
> HDFS-1753.4.patch, HDFS-1753.patch
>
>
> In doGet Method,
> final DFSInputStream in = dfs.open(filename);
> final long fileLen = in.getFileLength();
> OutputStream os = response.getOutputStream();
> Here this lines are present at out side of the try block.
> If response.getOutputStream() throws any exception then DFSInputStream will
> not be closed.So, better to move response.getOutputStream() into try block.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
