[ 
https://issues.apache.org/jira/browse/HDFS-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427275#comment-16427275
 ] 

Xiao Chen commented on HDFS-13363:
----------------------------------

Thanks all for the work and discussion here.
{code:java}
  String path = FSDirectory.resolveLastINode(iip).getFullPathName();{code}
Haven't dug into the code to see why, so apologies if I missed anything... Can 
we use the input parameter {{src}} / {{srcArg}} here, and save the resolution? 
Security seems fine since we only handle AclException here, and ACE would just 
be thrown out.

> Record file path when FSDirAclOp throws AclException
> ----------------------------------------------------
>
>                 Key: HDFS-13363
>                 URL: https://issues.apache.org/jira/browse/HDFS-13363
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Wei-Chiu Chuang
>            Assignee: Gabor Bota
>            Priority: Minor
>         Attachments: HDFS-13363.001.patch, HDFS-13363.002.patch
>
>
> When AclTransformation methods throws AclException, it does not record the 
> file path that has the exception. Therefore even if it throws an exception, 
> we would never know which file has those invalid ACLs.
>  
> These AclTransformation methods are invoked in FSDirAclOp methods, which know 
> the file path. These FSDirAclOp methods can catch AclException, and then add 
> the file path in the error message.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to