[
https://issues.apache.org/jira/browse/HDFS-13384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427861#comment-16427861
]
Ajay Kumar edited comment on HDFS-13384 at 4/6/18 2:21 AM:
-----------------------------------------------------------
[~elgoiri] thanks for working on this. Overall patch looks good. Few comments
on patch v0:
* TestRouterRPCClientRetries
** Possibly remove L196-198, since jsonString0 is used for assertion later?
** Do we need to reset slow NN. i.e L239-241. As teardown will anyway stop the
cluster.
** Also seems removing line L222 L238 makes test shorter and possibly tests
same thing.
** Comment at line L193 mention 12 nodes. But i think there are 4 datanodes
and 4 namenodes.
** Rename setNNSlow to simulateSlowNN
* Introduce some reasonable timeout through junit rule.
* Rename SubclusterTimeoutException to SubClusterTimeoutException or
ClusterTimeoutException
I thought making subcluster0 slow will result in no of Live datanodes to 2 but
that is not the case. Would appreciate if you can share what i am missing in
this case.
was (Author: ajayydv):
[~elgoiri] thanks for working on this. Overall patch looks good. Few comments
on patch v1:
* TestRouterRPCClientRetries
** Possibly remove L196-198, since jsonString0 is used for assertion later?
** Do we need to reset slow NN. i.e L239-241. As teardown will anyway stop the
cluster.
** Also seems removing line L222 L238 makes test shorter and possibly tests
same thing.
** Comment at line L193 mention 12 nodes. But i think there are 4 datanodes
and 4 namenodes.
** Rename setNNSlow to simulateSlowNN
* Introduce some reasonable timeout through junit rule.
* Rename SubclusterTimeoutException to SubClusterTimeoutException or
ClusterTimeoutException
I thought making subcluster0 slow will result in no of Live datanodes to 2 but
that is not the case. Would appreciate if you can share what i am missing in
this case.
> RBF: Improve timeout RPC call mechanism
> ---------------------------------------
>
> Key: HDFS-13384
> URL: https://issues.apache.org/jira/browse/HDFS-13384
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Priority: Minor
> Attachments: HDFS-13384.000.patch
>
>
> When issuing RPC requests to subclusters, we have a time out mechanism
> introduced in HDFS-12273. We need to improve this is handled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
