[ 
https://issues.apache.org/jira/browse/HDFS-13410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429990#comment-16429990
 ] 

Yiqun Lin edited comment on HDFS-13410 at 4/9/18 3:44 AM:
----------------------------------------------------------

The patch looks good overall. Some minor comments:
 * {{assertEquals(STATE.NOTINITED, router.getServiceState())}} can be kept in 
test.
 * Can we rename {{testRouterRpc}} to 
{{testRouterRpcWithNoAvailableRemoteLocs}} or 
{{testRouterRpcWithNoSubclusters}}?
 * {{(MockResolver)}} need a space in the right of  {{')'}}.


was (Author: linyiqun):
The patch looks good overall. Some minor comments:
 * {{assertEquals(STATE.NOTINITED, router.getServiceState())}} can be kept in 
test.
 * Can we rename {{testRouterRpc}} to 
{{testRouterRpcWithNoAvailableRemoteLocs}}?
 * {{(MockResolver)}} need a space in the right of  {{')'}}.

> RBF: Support federation with no subclusters
> -------------------------------------------
>
>                 Key: HDFS-13410
>                 URL: https://issues.apache.org/jira/browse/HDFS-13410
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: Íñigo Goiri
>            Priority: Minor
>         Attachments: HDFS-13410.000.patch, HDFS-13410.001.patch
>
>
> If the federation has no subclusters the logs have long stack traces. Even 
> though this is not a regular setup for RBF, we should trigger log message.
> An example:
> {code}
> Caused by: java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
>       at java.util.LinkedList.checkElementIndex(LinkedList.java:555)
>       at java.util.LinkedList.get(LinkedList.java:476)
>       at 
> org.apache.hadoop.hdfs.server.federation.router.RouterRpcClient.invokeConcurrent(RouterRpcClient.java:1028)
>       at 
> org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer.getDatanodeReport(RouterRpcServer.java:1264)
>       at 
> org.apache.hadoop.hdfs.server.federation.metrics.FederationMetrics.getNodeUsage(FederationMetrics.java:424)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to