[ 
https://issues.apache.org/jira/browse/HDFS-13328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430011#comment-16430011
 ] 

Xiao Chen commented on HDFS-13328:
----------------------------------

Thanks [~surendrasingh] for revving!

I think the new throttling logic need to change {{startTime}} in the if loop, 
so it's done _every_ \{{readLockReportingThresholdMs}} instead of _after the 
first_ \{{readLockReportingThresholdMs}}. Otherwise LGTM

> Abstract ReencryptionHandler recursive logic in separate class.
> ---------------------------------------------------------------
>
>                 Key: HDFS-13328
>                 URL: https://issues.apache.org/jira/browse/HDFS-13328
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Surendra Singh Lilhore
>            Assignee: Surendra Singh Lilhore
>            Priority: Major
>         Attachments: HDFS-13328-01.patch, HDFS-13328-02.patch, 
> HDFS-13328-03.patch
>
>
> HDFS-10899 added DFS logic to scan a directory. It is good to abstract this 
> logic in separate class, so it can be used in some other feature like 
> SPS(HDFS-10285). I already tried abstracting DFS logic in HDFS-12291 and same 
> can be pushed in trunk.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to