[
https://issues.apache.org/jira/browse/HDFS-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431608#comment-16431608
]
Dibyendu Karmakar commented on HDFS-13386:
------------------------------------------
Thanks [~elgoiri] for your review comments. I have handled the style related
comments.
{quote}I'm not sure is needed to do a listStatus and a getPartialListing,
shouldn't we be able to check the dates directly?
{quote}
Here listStatus is done to get the list from the NN. Then we are doing
{code:java}
DirectoryListing listing =
routerProtocol.getListing("/", HdfsFileStatus.EMPTY_NAME, false);
{code}
to get the listing from router and after that we are verifying the time
returned by NN and router.
{quote}We could also check that the number of entries is the expected.
{quote}
This I will do.
{quote}Right now it looks a little bit complicated for what we want to check
which is basically that the time of the new files/folders/mount table entries
is bigger than the initial time.
{quote}
We want to check that the time of the new files/folders/mount table entries is
bigger than the initial time and the time is same as mount table entry(for the
mount points) and the time returned by NN(for files/folders returned by NN).
Please suggest whether we are good with
{code:java}
assertTrue(currentTime > beforeCreatingTime);
assertEquals(currentTime, expectedTime);
{code}
these checks or {quote} new files/folders/mount table entries is bigger than
the initial time. {quote} this is sufficient.
> RBF: Wrong date information in list file(-ls) result
> ----------------------------------------------------
>
> Key: HDFS-13386
> URL: https://issues.apache.org/jira/browse/HDFS-13386
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Dibyendu Karmakar
> Assignee: Dibyendu Karmakar
> Priority: Minor
> Attachments: HDFS-13386-002.patch, HDFS-13386-003.patch,
> HDFS-13386-004.patch, HDFS-13386.000.patch, HDFS-13386.001.patch,
> image-2018-04-03-11-59-51-623.png
>
>
> # hdfs dfs -ls
> !image-2018-04-03-11-59-51-623.png!
> this is happening because getMountPointDates is not implemented
> {code:java}
> private Map<String, Long> getMountPointDates(String path) {
> Map<String, Long> ret = new TreeMap<>();
> // TODO add when we have a Mount Table
> return ret;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
