Nanda kumar commented on HDFS-13324:

Thanks [~shashikant] for taking this up and working on it. Please find my 
review comments below

L75: This line can be removed.

L101, L102: These lines should be removed.
L109: {{infoPort, infoSecurePort }} should be removed form the INSERT String.

convertNodePoolDB: javadoc should be updated for {{datanodeInfo}} table.

> Ozone: Remove InfoPort and InfoSecurePort from DatanodeDetails
> --------------------------------------------------------------
>                 Key: HDFS-13324
>                 URL: https://issues.apache.org/jira/browse/HDFS-13324
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Nanda kumar
>            Assignee: Shashikant Banerjee
>            Priority: Major
>              Labels: newbie
>         Attachments: HDFS-13324-HDFS-7240.000.patch, 
> HDFS-13324-HDFS-7240.001.patch
> We have removed the dependency of DatanodeID in HDSL/Ozone and there is no 
> need for InfoPort and InfoSecurePort.  It is now safe to remove InfoPort and 
> InfoSecurePort from DatanodeDetails.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to