[ 
https://issues.apache.org/jira/browse/HDFS-13428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434851#comment-16434851
 ] 

BELUGA BEHR commented on HDFS-13428:
------------------------------------

[~elgoiri] 
[https://stackoverflow.com/questions/322715/when-to-use-linkedlist-over-arraylist]

 

I'm just a tech working by day and enthusiast/hobbyist by night.  I like 
contributing to the open source community, making the world a little bit better 
through coding.  I just open random files and review them with a focus on 
polish and making small improvements for performance and code 
clarity/conciseness. 

> RBF: Remove LinkedList From StateStoreFileImpl.java
> ---------------------------------------------------
>
>                 Key: HDFS-13428
>                 URL: https://issues.apache.org/jira/browse/HDFS-13428
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: federation
>    Affects Versions: 3.0.1
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Trivial
>         Attachments: HDFS-13428.1.patch
>
>
> Replace {{LinkedList}} with {{ArrayList}} implementation in the 
> StateStoreFileImpl class.  This is especially advantageous because we can 
> pre-allocate the internal array before a copy occurs.  {{ArrayList}} is 
> faster for iterations and requires less memory than {{LinkedList}}.
> {code:java}
>   protected List<String> getChildren(String path) {
>     List<String> ret = new LinkedList<>();
>     File dir = new File(path);
>     File[] files = dir.listFiles();
>     if (files != null) {
>       for (File file : files) {
>         String filename = file.getName();
>         ret.add(filename);
>       }
>     }
>     return ret;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to