[ 
https://issues.apache.org/jira/browse/HDFS-13197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436283#comment-16436283
 ] 

Xiaoyu Yao commented on HDFS-13197:
-----------------------------------

Thanks [~ajayydv] for fixing this. The patch looks good to me overall. I tried 
it with the docker deployment and it seems the original issue was fixed with 
this patch.

Here are few minor issues:

HddsConfServlet.java

Line 139: unused method can be removed.

Line 158: ozone.enabled was retrieved but not used? If we don't need, this can 
be removed.

 

> Ozone: Fix ConfServlet#getOzoneTags cmd after HADOOP-15007
> ----------------------------------------------------------
>
>                 Key: HDFS-13197
>                 URL: https://issues.apache.org/jira/browse/HDFS-13197
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: HDFS-7240
>            Reporter: Xiaoyu Yao
>            Assignee: Ajay Kumar
>            Priority: Major
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-13197-HDFS-7240.000.patch, 
> HDFS-13197-HDFS-7240.001.patch, HDFS-13197-HDFS-7240.002.patch, Screen Shot 
> 2018-04-10 at 2.05.35 PM.png
>
>
> This is broken after merging trunk change HADOOP-15007 into HDFS-7240 branch. 
> I remove the cmd and related test to have a clean merge. [~ajakumar], please 
> fix the cmd and bring back the related test. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to