[
https://issues.apache.org/jira/browse/HDFS-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437485#comment-16437485
]
Íñigo Goiri edited comment on HDFS-13435 at 4/13/18 4:02 PM:
-------------------------------------------------------------
Not sure I would add the full stack trace for a couple of those:
* FederationMetrics#268, I think that the message should enough in this case to
know if it's the JSON or the network that fails.
* RouterRpcServer#2373, I think the message should be enough.
* StateStoreZooKeeperImpl usually gets pretty decent messages from curator.
Maybe we could extend the tests to trigger more of these errors.
I think the main issue at this point is that we use IOException for everything
and it's hard to tell which one is what.
was (Author: elgoiri):
Not sure I would add the full stack trace for a couple of those:
* FederationMetrics#268, I think that the message should enough in this case to
know if it's the JSON or the network that fails.
* RouterRpcServer#2373, I think the message should be enough.
* StateStoreZooKeeperImpl usually gets pretty decent messages from curator.
Maybe we could extend the tests to trigger more of these errors.
I think the main issue at this point is that we use IOException for everything
and it's hard to tell which one is what.
> RBF: Improve the error loggings for printing the stack trace
> ------------------------------------------------------------
>
> Key: HDFS-13435
> URL: https://issues.apache.org/jira/browse/HDFS-13435
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 3.0.1
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Priority: Major
> Attachments: HDFS-13435.001.patch, HDFS-13435.002.patch
>
>
> There are many places that using {{Logger.error(String format, Object...
> arguments)}} incorrectly.
> A example:
> {code:java}
> LOG.error("Cannot remove {}", path, e);
> {code}
> The exception passed here is no meaning and won't be printed. Actually it
> should be update to
> {code:java}
> LOG.error("Cannot remove {}: {}.", path, e.getMessage());
> {code}
> or
> {code:java}
> LOG.error("Cannot remove " + path, e));
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
