[ 
https://issues.apache.org/jira/browse/HDFS-13330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437658#comment-16437658
 ] 

genericqa commented on HDFS-13330:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red}  1m  
7s{color} | {color:red} Docker failed to build yetus/hadoop:f667ef1. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-13330 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12918984/HDFS-13330.branch-2.patch
 |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23930/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> ShortCircuitCache#fetchOrCreate never retries
> ---------------------------------------------
>
>                 Key: HDFS-13330
>                 URL: https://issues.apache.org/jira/browse/HDFS-13330
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Wei-Chiu Chuang
>            Assignee: Gabor Bota
>            Priority: Major
>             Fix For: 3.2.0
>
>         Attachments: HDFS-13330.001.patch, HDFS-13330.002.patch, 
> HDFS-13330.004.patch, HDFS-13330.005.patch, HDFS-13330.branch-2.patch
>
>
> The follow do .. while(false) loop seems useless to me. The code intended to 
> retry but it never worked. Let's fix it.
> {code:java:title=ShortCircuitCache#fetchOrCreate}
> ShortCircuitReplicaInfo info = null;
> do {
>   if (closed) {
>     LOG.trace("{}: can't fethchOrCreate {} because the cache is closed.",
>         this, key);
>     return null;
>   }
>   Waitable<ShortCircuitReplicaInfo> waitable = replicaInfoMap.get(key);
>   if (waitable != null) {
>     try {
>       info = fetch(key, waitable);
>     } catch (RetriableException e) {
>       LOG.debug("{}: retrying {}", this, e.getMessage());
>     }
>   }
> } while (false);{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to