Mukul Kumar Singh commented on HDFS-13424:

Thanks for working on this [~nandakumar131]. The code looks good to me. I 
concentrated on changes in HddsDatanodeService and MiniOzoneClusterImpl.

I feel that we can have two implementations for MiniOzoneCluster.
1) MiniOzoneClassicCluster: this can be the new implementation without hdfs 
related components.
2) MiniOzoneHdfsCluster: where Ozone is created over hdfs datanode. (we 
necessarily do not need to support all the apis)

I feel that this approach will help in making sure that the plugin inside hdfs 
datanode work correctly as well.

Some minor nitpicks in code.
1) HddsDatanodeService:190, the indentation for 190-192 is wrong
2) OzoneContract:41, unused import.

> Ozone: Refactor MiniOzoneClassicCluster
> ---------------------------------------
>                 Key: HDFS-13424
>                 URL: https://issues.apache.org/jira/browse/HDFS-13424
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Nanda kumar
>            Assignee: Nanda kumar
>            Priority: Major
>         Attachments: HDFS-13424-HDFS-7240.000.patch
> This jira will track the refactoring work on {{MiniOzoneClassicCluster}} 
> which removes the dependency and changes made in {{MiniDFSCluster}}

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to