Nanda kumar commented on HDFS-13444:

Thanks [~ljain] for working on this. The patch looks pretty good to me, some 
minor comments.

*The following classes are missing javadoc*
 * HddsConfServlet#BadFormatException
 * HddsConfigKeys
 * BenchMarkMetadataStoreWrites
 * BenchMarkRocksDbStore
 * BenchMarkDatanodeDispatcher
 * BenchMarkContainerStateMap
 * BenchMarkMetadataStoreReads

RegisteredCommand.java:198 'hostname' hides a field - rename the setter method 
argument to 'host'
RegisteredCommand.java:203 'ipAddress' hides a field - rename the setter method 
argument to 'ip'

*Lines length more than 80 characters*

Make both {{stateMap}} and {{containerID}} as private.

Variable name {{stateManager}} is already used at the class lever, rename it to 

*Unused imports*
BenchMarkContainerStateMap.java:48 & 49

> Ozone: Fix checkstyle issues in HDFS-7240
> -----------------------------------------
>                 Key: HDFS-13444
>                 URL: https://issues.apache.org/jira/browse/HDFS-13444
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Lokesh Jain
>            Assignee: Lokesh Jain
>            Priority: Major
>         Attachments: HDFS-13444-HDFS-7240.001.patch, HDFS-7240.007.patch

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to