[ https://issues.apache.org/jira/browse/HDFS-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439683#comment-16439683 ]
Íñigo Goiri commented on HDFS-13435: ------------------------------------ [^HDFS-13435.003.patch] LGTM. We can tune these in the future if we think they are too verbose. For now, this should be good. > RBF: Improve the error loggings for printing the stack trace > ------------------------------------------------------------ > > Key: HDFS-13435 > URL: https://issues.apache.org/jira/browse/HDFS-13435 > Project: Hadoop HDFS > Issue Type: Sub-task > Affects Versions: 3.0.1 > Reporter: Yiqun Lin > Assignee: Yiqun Lin > Priority: Major > Attachments: HDFS-13435.001.patch, HDFS-13435.002.patch, > HDFS-13435.003.patch > > > There are many places that using {{Logger.error(String format, Object... > arguments)}} incorrectly. > A example: > {code:java} > LOG.error("Cannot remove {}", path, e); > {code} > The exception passed here is no meaning and won't be printed. Actually it > should be update to > {code:java} > LOG.error("Cannot remove {}: {}.", path, e.getMessage()); > {code} > or > {code:java} > LOG.error("Cannot remove " + path, e)); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org