[ 
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439714#comment-16439714
 ] 

Wei Yan edited comment on HDFS-13326 at 4/16/18 4:58 PM:
---------------------------------------------------------

Thanks [~gangli2384] for [^HDFS-13326.001.patch]. Please fix the checkstyle 
errors, most are 80-character issues.

In *RouterAdmin.java*:

The error msg 
{quote}"Cannot add destination at an existing mount point " + mount);
{quote}
can be updated to 
{quote}"Cannot add destination to an existing mount point. Please use -update 
cmd."
{quote}
For *TestRouterAdminCLI.java*: we can merge multiple test functions together. 
Don't need to check field updates one by one :)

[~elgoiri] [~linyiqun] do u guys have any more comments? We are changing the 
original "-add" cmd, just to make sure it doesn't break anything from you guy 
side.


was (Author: ywskycn):
Thanks [~gangli2384] for [^HDFS-13326.001.patch]. Please fix the checkstyle 
errors, most are 80-character issues.

In *RouterAdmin.java*:

The error msg 
{quote}"Cannot add destination at an existing mount point " + mount);
{quote}
can be updated to 
{quote}"Cannot add destination to an existing mount point. Please use -update 
cmd."
{quote}
For *TestRouterAdminCLI.java*: we can merge multiple test functions together. 
Don't need to check field updates one by one :)

[~elgoiri] [~linyiqun] do u guys have any more comments? We are changing the 
original "-add" cmd, just to make sure it doesn't break anything from you guy 
side.

 

 

> RBF: Improve the interfaces to modify and view mount tables
> -----------------------------------------------------------
>
>                 Key: HDFS-13326
>                 URL: https://issues.apache.org/jira/browse/HDFS-13326
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Wei Yan
>            Assignee: Gang Li
>            Priority: Minor
>         Attachments: HDFS-13326.000.patch, HDFS-13326.001.patch
>
>
> From DFSRouterAdmin cmd, currently the update logic is implemented inside add 
> operation, where it has some limitation (e.g. cannot update "readonly" or 
> removing a destination).  Given the RPC alreadys separate add and update 
> operations, it would be better to do the same in cmd level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to