[ 
https://issues.apache.org/jira/browse/HDFS-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yiqun Lin updated HDFS-13435:
-----------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 3.0.4
                   2.9.2
                   3.1.1
                   3.2.0
                   2.10.0
           Status: Resolved  (was: Patch Available)

Committed to trunk, branch-3.1, branch-3.0, branch-2 and branch-2.9.
Thanks [~elgoiri], [~ywskycn] and [~ajayydv] for the review and discussion!

> RBF: Improve the error loggings for printing the stack trace
> ------------------------------------------------------------
>
>                 Key: HDFS-13435
>                 URL: https://issues.apache.org/jira/browse/HDFS-13435
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 3.0.1
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>            Priority: Major
>             Fix For: 2.10.0, 3.2.0, 3.1.1, 2.9.2, 3.0.4
>
>         Attachments: HDFS-13435.001.patch, HDFS-13435.002.patch, 
> HDFS-13435.003.patch
>
>
> There are many places that using {{Logger.error(String format, Object... 
> arguments)}} incorrectly.
>  A example:
> {code:java}
> LOG.error("Cannot remove {}", path, e);
> {code}
> The exception passed here is no meaning and won't be printed. Actually it 
> should be update to
> {code:java}
> LOG.error("Cannot remove {}: {}.", path, e.getMessage());
> {code}
> or 
> {code:java}
> LOG.error("Cannot remove " +  path, e));
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to