[ 
https://issues.apache.org/jira/browse/HDFS-13403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446056#comment-16446056
 ] 

Istvan Fajth commented on HDFS-13403:
-------------------------------------

Hi [~James C],

yes, those are one type of the warnings, also I see warnings due to 
-Wunused-lambda-capture though after checking a few instance of this warning, 
they not seems to be related to this patch, though I just vaguely checked, but 
most likely they were there before as well.

With the patch applied, I do not see inconsistent-missing-override warnings, 
and the include helped as well to get over the compile error.

> libhdfs++: Use hdfs::IoService object rather than asio::io_service
> ------------------------------------------------------------------
>
>                 Key: HDFS-13403
>                 URL: https://issues.apache.org/jira/browse/HDFS-13403
>             Project: Hadoop HDFS
>          Issue Type: Task
>            Reporter: James Clampffer
>            Assignee: James Clampffer
>            Priority: Critical
>         Attachments: HDFS-13403.000.patch, build_fixes.patch
>
>
> At the moment the hdfs::IoService is a simple wrapper over asio's io_service 
> object.  I'd like to make this smarter and have it do things like track which 
> tasks are queued, validate that dependencies of tasks exist, and monitor 
> ioservice throughput and contention.  In order to get there we need to use 
> have all components in the library to go through the hdfs::IoService rather 
> than directly interacting with the asio::io_service.  The only time the 
> asio::io_service should be used is when calling things like asio::async_write 
> that need an io_service&.  HDFS-11884 will be able get rid of those remaining 
> instances once this work is in place.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to