[
https://issues.apache.org/jira/browse/HDFS-13484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447864#comment-16447864
]
Yiqun Lin edited comment on HDFS-13484 at 4/23/18 10:05 AM:
------------------------------------------------------------
Thanks [~elgoiri] for updating the patch. Some comments:
*MembershipNamenodeResolver.java*
line190: We need to do the additional try-catch for getting disabled
nameservices and logging the error.
*RouterAdminServer.java*
line328: Can we also print the log like that did in disable rpc did:
{{LOG.error("Cannot enable {}, it does not exists", nsId);}}
The related change of disabled nameservices UI can be moved into follow-up
JIRA: {{federationhealth.html}}, {{federationhealth.js}}, {{rbf.css}}
*TestDisableNameservices.java*
{{testWithoutDisabling/testDisabling}} looks a little complex. Simulating the
subcluster is not a necessary operation, We use the router client to create
file under the enable/disbale cases. For the verification, a easier way without
waitting for the repsonse: Use actual namenode client to query.
*TestRouterAdmin.java*
line100 and 102: These two lines are completely same.
line116: This line can be placed in the end of
{{testNamespaceManagerUnauthorized}}.
In addition, would you mind updating the doc for the disable nameservice cmd as
well?
was (Author: linyiqun):
Thanks [~elgoiri] for updating the patch. Some comments:
*MembershipNamenodeResolver.java*
line190: We need to do the additional try-catch for getting disabled
nameservices and logging the error.
*RouterAdminServer.java*
line328: Can we also print the log like that did in disable rpc did:
{{LOG.error("Cannot enable {}, it does not exists", nsId);}}
The related change of disabled nameservices UI can be moved into follow-up
JIRA: {{federationhealth.html}}, {{federationhealth.js}}, {{rbf.css}}
*TestDisableNameservices.java*
{{testWithoutDisabling/testDisabling}} looks a little complex. Simulating the
subcluster is not a necessary operation, We use the router client to create
file under the enable/disbale cases. For the verification, a easier way without
waitting for the repsonse: Use actual namenode client to query.
*TestRouterAdmin.java*
line100 and 102: These two lines are completely same.
line116: This line can be placed in the end of
{{testNamespaceManagerUnauthorized}}.
> RBF: Disable Nameservices from the federation
> ---------------------------------------------
>
> Key: HDFS-13484
> URL: https://issues.apache.org/jira/browse/HDFS-13484
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Priority: Major
> Attachments: HDFS-13484.000.patch, HDFS-13484.001.patch,
> HDFS-13484.002.patch, HDFS-13484.003.patch, HDFS-13484.004.patch
>
>
> HDFS-13478 introduced the Decommission store. We should disable the access to
> decommissioned subclusters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
