[
https://issues.apache.org/jira/browse/HDFS-13484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449417#comment-16449417
]
Yiqun Lin commented on HDFS-13484:
----------------------------------
Thanks for the clarifications, [~elgoiri].
{quote}
UI changes: the only thing to move to the other JIRA would be the HTML, JS and
CSS files, right? If so we could do that without any unit tests. What else
would that go there?
{quote}
Besides HTML, JS and CSS files, it would be better to attach the screen-shot in
the follow-up JIRA as well.
Some minor comments for the latest patch:
*MembershipNamenodeResolver.java*
line126: {{MembershipStore disabled = getMembershipStore();}} should be
{{DisabledNameserviceStore disabled = getDisabledNameserviceStore();}}
*HDFSRouterFederation.md*
* {noformat}
+ [hdfs]$ $HADOOP_HOME/bin/hdfs dfsrouteradmin -nameservices disable ns1
+ [hdfs]$ $HADOOP_HOME/bin/hdfs dfsrouteradmin -nameservices enable ns1
{noformat}
Typo {{-nameservices}} should be {{-nameservice}}.
* Would you mind adding nameservice disable command in HDFSCommands.md?
*TestRouterAdmin,java*
line102: {{ns0}} should update to {{ns1}}.
line403: Can we rename {{testNamespaceManagerUnauthorized}} to
{{testNameserviceManagerUnauthorized}}? And also rename namespace to
nameservice defined under this test method. Just to make this name consistent.
> RBF: Disable Nameservices from the federation
> ---------------------------------------------
>
> Key: HDFS-13484
> URL: https://issues.apache.org/jira/browse/HDFS-13484
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Priority: Major
> Attachments: HDFS-13484.000.patch, HDFS-13484.001.patch,
> HDFS-13484.002.patch, HDFS-13484.003.patch, HDFS-13484.004.patch,
> HDFS-13484.005.patch, HDFS-13484.006.patch, HDFS-13484.007.patch
>
>
> HDFS-13478 introduced the Decommission store. We should disable the access to
> decommissioned subclusters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
