[ 
https://issues.apache.org/jira/browse/HDFS-12655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451092#comment-16451092
 ] 

Hudson commented on HDFS-12655:
-------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14057 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/14057/])
HDFS-12655. Ozone: use specific names for RPC.Server instances. (aengineer: rev 
ee6dd3e2d2ecff680869d0c754b8dcaa7cb6dc67)
* (edit) 
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
* (edit) 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* (edit) 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java
* (edit) 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
* (edit) 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* (edit) 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java


> Ozone: use specific names for RPC.Server instances
> --------------------------------------------------
>
>                 Key: HDFS-12655
>                 URL: https://issues.apache.org/jira/browse/HDFS-12655
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-12655-HDFS-7240.001.patch, rpcmetrics.png
>
>
> My original motivation is using meaningful names on the scm web ui. As you 
> can see on the attached screenshot we display the metrics for all the RPC 
> servers (using hadoop metrics published on jmx). Unfortunatelly we can 
> display only the port number on the web ui as there are no meaningfull names 
> published on the jmx interface.
> After some investigation I found that there is a serverName constructor 
> parameter int Rpc.Server but it is NOT used currently.
> This patch will:
> 1. store the serverName in field of RPC.Server a 
> 2. Improve the way how the serverName is calculated from the protocol class 
> names (it's typically an anonnymous inner class, so I remove the unnecessary 
> $-s from the name.)
> 3. Add a new tag to the RpcMetrics based on the serverName field of the 
> Rpc.Server It will be displayed over JMX
> 4. Add unit tests for checking the tag values and the default 
> classname->servername mapping.
> ps: I need it for Ozone SCM web ui, but let ne know if it should be moved to 
> HADOOP project/trunk.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to