[
https://issues.apache.org/jira/browse/HDFS-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061698#comment-13061698
]
Todd Lipcon commented on HDFS-1981:
-----------------------------------
- As Konstantin said, please use Junit 4 (annotations API) instead of Junit 3,
and use the MiniDFSCluster builder
- typo: NEW_EIDTS_STREAM
- don't use the string constant "dfs.name.dir" - there are constants in
DFSConfigKeys for this
- "false == editsNew.exists()" ?? !editsNew.exists()
- TODOs in the test case. don't swallow exceptions
- you can use IOUtils.cleanup or IOUtils.closeStream in the finally block
inside of the block
- no need to clear editsStreams in teardown method - it's an instance var so it
will be recreated for each case anyway
- what's the purpose of the setup which creates bImg? It's not used in any of
the test cases.
- assertion text is wrong: "image should be deleted" -- but it's checking that
"edits.new" should be deleted.
> When namenode goes down while checkpointing and if is started again
> subsequent Checkpointing is always failing
> --------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-1981
> URL: https://issues.apache.org/jira/browse/HDFS-1981
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.22.0
> Environment: Linux
> Reporter: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.22.0
>
> Attachments: HDFS-1981-1.patch, HDFS-1981.patch
>
>
> This scenario is applicable in NN and BNN case.
> When the namenode goes down after creating the edits.new, on subsequent
> restart the divertFileStreams will not happen to edits.new as the edits.new
> file is already present and the size is zero.
> so on trying to saveCheckPoint an exception occurs
> 2011-05-23 16:38:57,476 WARN org.mortbay.log: /getimage: java.io.IOException:
> GetImage failed. java.io.IOException: Namenode has an edit log with timestamp
> of 2011-05-23 16:38:56 but new checkpoint was created using editlog with
> timestamp 2011-05-23 16:37:30. Checkpoint Aborted.
> This is a bug or is that the behaviour.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
