[
https://issues.apache.org/jira/browse/HDFS-13454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456260#comment-16456260
]
genericqa commented on HDFS-13454:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
32s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 25m
15s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
14s{color} | {color:red} integration-test in trunk failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
15s{color} | {color:red} integration-test in trunk failed. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 58s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-ozone/integration-test {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
0s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
15s{color} | {color:red} integration-test in trunk failed. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
10s{color} | {color:red} integration-test in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
10s{color} | {color:red} integration-test in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 10s{color}
| {color:red} integration-test in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
8s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
11s{color} | {color:red} integration-test in the patch failed. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 33s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-ozone/integration-test {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
0s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
13s{color} | {color:red} integration-test in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 13s{color}
| {color:red} integration-test in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 51m 15s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDFS-13454 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12920994/HDFS-13454.000.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux c362be038772 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 84ecfe3 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_162 |
| compile |
https://builds.apache.org/job/PreCommit-HDFS-Build/24090/artifact/out/branch-compile-hadoop-ozone_integration-test.txt
|
| mvnsite |
https://builds.apache.org/job/PreCommit-HDFS-Build/24090/artifact/out/branch-mvnsite-hadoop-ozone_integration-test.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HDFS-Build/24090/artifact/out/branch-javadoc-hadoop-ozone_integration-test.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HDFS-Build/24090/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HDFS-Build/24090/artifact/out/patch-compile-hadoop-ozone_integration-test.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HDFS-Build/24090/artifact/out/patch-compile-hadoop-ozone_integration-test.txt
|
| mvnsite |
https://builds.apache.org/job/PreCommit-HDFS-Build/24090/artifact/out/patch-mvnsite-hadoop-ozone_integration-test.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HDFS-Build/24090/artifact/out/patch-javadoc-hadoop-ozone_integration-test.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/24090/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/24090/testReport/ |
| Max. process+thread count | 301 (vs. ulimit of 10000) |
| modules | C: hadoop-ozone/integration-test U: hadoop-ozone/integration-test |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/24090/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Ozone : Fix the test logic in TestKeySpaceManager#testDeleteKey
> ---------------------------------------------------------------
>
> Key: HDFS-13454
> URL: https://issues.apache.org/jira/browse/HDFS-13454
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Fix For: HDFS-7240
>
> Attachments: HDFS-13454-HDFS-7240.000.patch, HDFS-13454.000.patch
>
>
> The test logic in TestKeySpaceManager#testDeleteKey seems to be wrong. The
> test validates the keyArgs instead of blockId to make sure the key gets
> deleted from SCM. Also, after the first exception validation , the subsequent
> statements in the junit never gets executed here.
> {code:java}
> keys.add(keyArgs.getResourceName());
> exception.expect(IOException.class);
> exception.expectMessage("Specified block key does not exist");
> cluster.getStorageContainerManager().getBlockLocations(keys);
> // Delete the key again to test deleting non-existing key.
> // These will never get executed.
> exception.expect(IOException.class);
> exception.expectMessage("KEY_NOT_FOUND");
> storageHandler.deleteKey(keyArgs);
> Assert.assertEquals(1 + numKeyDeleteFails,
> ksmMetrics.getNumKeyDeletesFails());{code}
> The test needs to be modified to address all these.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
