[ 
https://issues.apache.org/jira/browse/HDFS-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457054#comment-16457054
 ] 

Xiao Liang commented on HDFS-13509:
-----------------------------------

For my local test of branch-2, currently without the patch it failed to finish:

{color:#d04437}[INFO] 
-------------------------------------------------------{color}
{color:#d04437}[INFO] T E S T S{color}
{color:#d04437}[INFO] 
-------------------------------------------------------{color}
{color:#d04437}[INFO] Running org.apache.hadoop.hdfs.TestFileAppend{color}
{color:#d04437}[ERROR] Tests run: 13, Failures: 0, Errors: 4, Skipped: 0, Time 
elapsed: 46.473 s <<< FAILURE! - in org.apache.hadoop.hdfs.TestFileAppend{color}
{color:#d04437}[ERROR] 
testFailedAppendBlockRejection(org.apache.hadoop.hdfs.TestFileAppend) Time 
elapsed: 1.269 s <<< ERROR!{color}
{color:#d04437}java.io.IOException:{color}
{color:#d04437}Cannot remove data directory: 
D:\Git\Hadoop\hadoop-hdfs-project\hadoop-hdfs\target\test\data\dfs\datapath 
'D:\Git\Hadoop\hadoop-hdfs-project\hadoop-hdfs\target\test\data\dfs\data':{color}
{color:#d04437} 
absolute:D:\Git\Hadoop\hadoop-hdfs-project\hadoop-hdfs\target\test\data\dfs\data{color}
{color:#d04437} permissions: drwx{color}

And with the patch the result is:

{color:#14892c}[INFO] 
-------------------------------------------------------{color}
{color:#14892c}[INFO] T E S T S{color}
{color:#14892c}[INFO] 
-------------------------------------------------------{color}
{color:#14892c}[INFO] Running org.apache.hadoop.hdfs.TestFileAppend{color}
{color:#14892c}[INFO] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time 
elapsed: 56.192 s - in org.apache.hadoop.hdfs.TestFileAppend{color}
{color:#14892c}[INFO]{color}
{color:#14892c}[INFO] Results:{color}
{color:#14892c}[INFO]{color}
{color:#14892c}[INFO] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0{color}
{color:#14892c}[INFO]{color}
{color:#14892c}[INFO] 
------------------------------------------------------------------------{color}
{color:#14892c}[INFO] BUILD SUCCESS{color}
{color:#14892c}[INFO] 
------------------------------------------------------------------------{color}
{color:#14892c}[INFO] Total time: 01:05 min{color}
{color:#14892c}[INFO] Finished at: 2018-04-26T15:29:19-07:00{color}
{color:#14892c}[INFO] Final Memory: 33M/854M{color}
{color:#14892c}[INFO] 
------------------------------------------------------------------------{color}

> Bug fix for breakHardlinks() of ReplicaInfo/LocalReplica, and fix 
> TestFileAppend failures on Windows
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-13509
>                 URL: https://issues.apache.org/jira/browse/HDFS-13509
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Xiao Liang
>            Assignee: Xiao Liang
>            Priority: Major
>              Labels: windows
>         Attachments: HDFS-13509-branch-2.000.patch, HDFS-13509.000.patch
>
>
> breakHardlinks() of ReplicaInfo(branch-2)/LocalReplica(trunk) replaces file 
> while the source is still opened as input stream, which will fail and throw 
> exception on Windows. It's the cause of  unit test case 
> org.apache.hadoop.hdfs.TestFileAppend#testBreakHardlinksIfNeeded failure on 
> Windows.
> Other test cases of TestFileAppend fail randomly on Windows due to sharing 
> the same test folder, and the solution is using randomized base dir of 
> MiniDFSCluster via HDFS-13408



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to