[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457303#comment-16457303
]
Íñigo Goiri edited comment on HDFS-13245 at 4/28/18 2:25 AM:
-------------------------------------------------------------
Thanks for adding the unit tests in [^HDFS-13245.004.patch].
Some comments:
* We should fix most of those checkstyle errors.
* Another thing is we should have proper capitalization like SQL and MySQL over
the patch.
* We should create a utility class to keep the SQL definitions and the static
operations.
* The getDbType() should be VisibleForTesting.
A more general question, now we have also a table for DisabledNamespaces,
shouldn't these tests fail as we are not adding them?
was (Author: elgoiri):
Thanks for adding the unit tests in [^HDFS-13245.004.patch].
Some comments:
* We should fix most of those checkstyle errors.
* Another thing is we should have proper capitalization like SQL and MySQL over
the patch.
* We should create a utility class to keep the SQL definitions and the static
operations.
* The getDbType() should be VisibleForTesting.
A more general question, now we have also a table for DisabledNamespaces,
shouldn't this tests fail as we are not adding them?
> RBF: State store DBMS implementation
> ------------------------------------
>
> Key: HDFS-13245
> URL: https://issues.apache.org/jira/browse/HDFS-13245
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: maobaolong
> Assignee: Yiran Wu
> Priority: Major
> Attachments: HDFS-13245.001.patch, HDFS-13245.002.patch,
> HDFS-13245.003.patch, HDFS-13245.004.patch
>
>
> Add a DBMS implementation for the State Store.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
