[
https://issues.apache.org/jira/browse/HDDS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460217#comment-16460217
]
Xiaoyu Yao commented on HDDS-15:
--------------------------------
Patch looks good to me overall. Just two minor issues:
Genesis.java
Line 47: NIT: the ident/format needs to be adjusted after the comment.
GenesisMemoryProfiler.java
Line 28: should we sample to get the max used heap instead of total heap that
includes both used and free?
long usedHeap = Runtime.getRuntime().totalMemory() -
Runtime.getRuntime().freeMemory();
> Add memory profiler support to Genesis
> --------------------------------------
>
> Key: HDDS-15
> URL: https://issues.apache.org/jira/browse/HDDS-15
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Tools
> Affects Versions: 0.2.1
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-15.001.patch
>
>
> Add the ability to sample max memory usage when running tests under Genesis.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
