[ 
https://issues.apache.org/jira/browse/HDFS-13512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463004#comment-16463004
 ] 

Ajay Kumar edited comment on HDFS-13512 at 5/3/18 9:57 PM:
-----------------------------------------------------------

[~shahrs87]
{quote}I am wondering why we want to preserve ecPolicy in json payload that 
server sends.
On the client side, WebhdfsFileSystem is not even reading ecPolicy from 
json.{quote}
As pointed out by [~hanishakoneru] removing this may break backward 
compatibility. Although we haven't documented it, json returned from webhdfs 
has that field. There might be clients using it via curl.
{quote}While going through history of adding erasure coding policy in 
DistributedFileSystem, I came across this jira HDFS-11565.
We should adopt the same logic in WebhdfsFileSystem also.{quote}
Its a good optimization but sending only id in case of system policies may not 
be very useful for curl. Also this will be less clean solution as we will be 
sending id for system defined policies and other field for other type of 
policies. Also as you earlier pointed out this is what we return in DFS.


was (Author: ajayydv):
[~shahrs87]
{quote}I am wondering why we want to preserve ecPolicy in json payload that 
server sends.
On the client side, WebhdfsFileSystem is not even reading ecPolicy from 
json.{quote}
As pointed out by [~hanishakoneru] removing this may break backward 
compatibility. Although we haven't documented it, json returned from webhdfs 
has that field. There might be clients using it via curl.
{quote}While going through history of adding erasure coding policy in 
DistributedFileSystem, I came across this jira HDFS-11565.
We should adopt the same logic in WebhdfsFileSystem also.{quote}
Its a good optimization but sending only id in case of system policies may not 
be very useful for curl. Also this will be less clean solution as we will be 
sending id for system defined policies and other field for other type of 
policies.

> WebHdfs getFileStatus doesn't return ecPolicy
> ---------------------------------------------
>
>                 Key: HDFS-13512
>                 URL: https://issues.apache.org/jira/browse/HDFS-13512
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Ajay Kumar
>            Assignee: Ajay Kumar
>            Priority: Major
>         Attachments: HDFS-13512.00.patch, HDFS-13512.01.patch, 
> HDFS-13512.02.patch, HDFS-13512.03.patch, HDFS-13512.04.patch, 
> HDFS-13512.05.patch
>
>
> Currently LISTSTATUS call to WebHdfs returns a json. These jsonArray elements 
> do have the ecPolicy name.
> But when WebHdfsFileSystem converts it back into a FileStatus object, the 
> ecPolicy is not added. This is because the json contains only the ecPolicy 
> name and this name is not sufficient to decode it back to ErasureCodingPolicy 
> object.
> While converting json back to HdfsFileStatus we should set ecPolicyName 
> whenever it is set for give file/dir.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to