[
https://issues.apache.org/jira/browse/HDFS-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464300#comment-16464300
]
Erik Krogen commented on HDFS-13286:
------------------------------------
Great! I agree with you on the RM side of things.
Your precommit is available
[here|https://builds.apache.org/job/PreCommit-HDFS-Build/24130]. It timed out
(5 hours) since it had changes in YARN, Common, and HDFS. Common/HDFS tests
were able to complete; YARN was killed. Given the tiny nature of the YARN
changes I am not worried about this.
These are the test failures reported:
{quote}
org.apache.hadoop.hdfs.TestSafeModeWithStripedFileWithRandomECPolicy.testStripedFile1
org.apache.hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations.testClusterIdMismatchAtStartupWithHA
org.apache.hadoop.hdfs.server.namenode.TestReencryptionWithKMS.testReencryptionKMSDown
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure.testUnderReplicationAfterVolFailure
org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA.testUpdatePipeline
{quote}
Which do not look related to this change.
The diff reports are clean except for [checkstyle|
https://builds.apache.org/job/PreCommit-HDFS-Build/24130/artifact/out/diff-checkstyle-root.txt]:
{quote}
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/DummyHAService.java:59:
boolean failToBecomeActive, failToBecomeStandby, failToBecomeObserver,:11:
Variable 'failToBecomeActive' must be private and have accessor methods.
[VisibilityModifier]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/DummyHAService.java:59:
boolean failToBecomeActive, failToBecomeStandby, failToBecomeObserver,:31:
Variable 'failToBecomeStandby' must be private and have accessor methods.
[VisibilityModifier]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/DummyHAService.java:59:
boolean failToBecomeActive, failToBecomeStandby, failToBecomeObserver,:52:
Variable 'failToBecomeObserver' must be private and have accessor methods.
[VisibilityModifier]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/DummyHAService.java:60:
failToFence;:7: Variable 'failToFence' must be private and have accessor
methods. [VisibilityModifier]
{quote}
These are primarily existing issues and I think it's okay to follow the
convention here.
I am going to commit this now.
> Add haadmin commands to transition between standby and observer
> ---------------------------------------------------------------
>
> Key: HDFS-13286
> URL: https://issues.apache.org/jira/browse/HDFS-13286
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chao Sun
> Assignee: Chao Sun
> Priority: Major
> Attachments: HDFS-13286-HDFS-12943.000.patch,
> HDFS-13286-HDFS-12943.001.patch, HDFS-13286-HDFS-12943.002.patch,
> HDFS-13286-HDFS-12943.003.patch, HDFS-13286-HDFS-12943.004.patch,
> HDFS-13286-HDFS-12943.005.patch
>
>
> As discussed in HDFS-12975, we should allow explicit transition between
> standby and observer through haadmin command, such as:
> {code}
> haadmin -transitionToObserver
> {code}
> Initially we should support transition from observer to standby, and standby
> to observer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
