[ 
https://issues.apache.org/jira/browse/HDDS-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mukul Kumar Singh moved HDFS-13454 to HDDS-33:
----------------------------------------------

       Fix Version/s:     (was: HDFS-7240)
                      0.2.1
    Target Version/s:   (was: HDFS-7240)
         Component/s:     (was: ozone)
                      Ozone Manager
            Workflow: patch-available, re-open possible  (was: 
no-reopen-closed, patch-avail)
                 Key: HDDS-33  (was: HDFS-13454)
             Project: Hadoop Distributed Data Store  (was: Hadoop HDFS)

> Ozone : Fix the test logic in TestKeySpaceManager#testDeleteKey
> ---------------------------------------------------------------
>
>                 Key: HDDS-33
>                 URL: https://issues.apache.org/jira/browse/HDDS-33
>             Project: Hadoop Distributed Data Store
>          Issue Type: Test
>          Components: Ozone Manager
>            Reporter: Shashikant Banerjee
>            Assignee: Shashikant Banerjee
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDFS-13454-HDFS-7240.000.patch, HDFS-13454.000.patch
>
>
> The test logic in TestKeySpaceManager#testDeleteKey seems to be wrong. The 
> test validates the keyArgs instead of blockId to make sure the key gets 
> deleted from SCM. Also, after the first exception validation , the subsequent 
> statements in the junit never gets executed here.
> {code:java}
> keys.add(keyArgs.getResourceName());
> exception.expect(IOException.class);
> exception.expectMessage("Specified block key does not exist");
> cluster.getStorageContainerManager().getBlockLocations(keys);
> // Delete the key again to test deleting non-existing key.
> // These will never get executed.
> exception.expect(IOException.class);
> exception.expectMessage("KEY_NOT_FOUND");
> storageHandler.deleteKey(keyArgs);
> Assert.assertEquals(1 + numKeyDeleteFails,
>     ksmMetrics.getNumKeyDeletesFails());{code}
> The test needs to be modified to address all these.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to