[ https://issues.apache.org/jira/browse/HDDS-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467991#comment-16467991 ]
Xiaoyu Yao commented on HDDS-6: ------------------------------- Thanks [~ajayydv] for the update. Patch v2 looks good to me. Just few more minor issue, +1 after that being fixed. Can you fix the Jenkins shellcheck and unit failure (testCompareXmlAgainstConfigurationClass) that are related? StorageContainerManager.java Line 277: NIT: logon->login ozone-default.xml Line 1054: "This property is dependent up on hadoop.security.authentication". => "When this property is true, hadoop.security.authentication should be Kerberos". Line 1060: can we leave the default empty like other hadoop services? (You will need to update the unit test to explicitly set these keys) The description can be reworded like: " The keytab file used by each SCM daemon to login as its service principal. The principal name is configured with ozone.scm.kerberos.principal." Line 1060: Leave the default empty. The description does not match the key. Suggested description: " "The SCM service principal. This is typically set to scm/_h...@realm.tld. Each SCM will substitute _HOST with its own fully qualified hostname at startup. The _HOST placeholder allows using the same configuration setting on both SCMs in an HA setup." > Enable SCM kerberos auth > ------------------------ > > Key: HDDS-6 > URL: https://issues.apache.org/jira/browse/HDDS-6 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Components: SCM, Security > Reporter: Ajay Kumar > Assignee: Ajay Kumar > Priority: Major > Fix For: 0.3.0 > > Attachments: HDDS-4-HDDS-6.00.patch, HDDS-6-HDDS-4.01.patch > > > Enable SCM kerberos auth -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org