[
https://issues.apache.org/jira/browse/HDFS-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469276#comment-16469276
]
Lei (Eddy) Xu commented on HDFS-13539:
--------------------------------------
Thanks Xiao for the patch.
Some minor comments:
* Could we change the function name {{getDataNodeCount()}} to
{{getCurrentBlockLocationsLength()}} ? It is private function and we dont need
synchronized for it.
* Are the {{synchronized}} added in {{DFSStripedInputStream}} relevant to the
fix? What about we only do the NPE fix in this patch?
The rest LGTM. +1 pending the fix.
> DFSInputStream NPE when reportCheckSumFailure
> ---------------------------------------------
>
> Key: HDFS-13539
> URL: https://issues.apache.org/jira/browse/HDFS-13539
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Xiao Chen
> Assignee: Xiao Chen
> Priority: Major
> Attachments: HDFS-13539.01.patch
>
>
> We have seem the following exception with DFSStripedInputStream.
> {noformat}
> readDirect: FSDataInputStream#read error:
> NullPointerException: java.lang.NullPointerException
> at
> org.apache.hadoop.hdfs.DFSStripedInputStream.readWithStrategy(DFSStripedInputStream.java:402)
> at org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:831)
> at
> org.apache.hadoop.fs.FSDataInputStream.read(FSDataInputStream.java:147)
> {noformat}
> Line 402 is {{reportCheckSumFailure}}, and {{currentLocatedBlock}} is the
> only possible null object. (Because {{currentLocatedBlock.getLocations()}}
> cannot be null - {{LocatedBlock}} constructor checks {{locs}} and would
> assign a {{EMPTY_LOCS}} if it's null)
> Original exception is masked by the NPE.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
