[ 
https://issues.apache.org/jira/browse/HDDS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469890#comment-16469890
 ] 

Anu Engineer commented on HDDS-38:
----------------------------------

[~shashikant] Thanks for taking care of this. Some high level thoughts.
 # We have to take care of two issues.
 ## Running out of space on a Node.
 ## Running out of space on Volume.
 # I am guessing that this patch takes care of the node issue. It is good and 
we can commit.
 # But before we do that, I wanted to see how we are going to take care of the 
Volume issue.
 ## To do that, Datanode has to send us a list of volumes and capacity and used.
 ## Should we aggregate that for each Node and infer this info, or do we still 
want the data node send both these reports seperate.
 ## I am ok, with NodeReport and aggregation over SCM stats – Just a question 
in my mind.

Otherwise patch looks good to me. One minor nit:

Would we please rename +private SCMNodeStat scmSta+t  to something like 
clusterStat.

> Add SCMNodeStorage map in SCM class to store storage statistics per Datanode
> ----------------------------------------------------------------------------
>
>                 Key: HDDS-38
>                 URL: https://issues.apache.org/jira/browse/HDDS-38
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: SCM
>            Reporter: Shashikant Banerjee
>            Assignee: Shashikant Banerjee
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-38.00.patch
>
>
> Currently , the storage stats per Datanode are maintained inside 
> scmNodeManager. This will
> move the scmNodeStats for storage outside SCMNodeManager to simplify 
> refactoring.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to