[
https://issues.apache.org/jira/browse/HDDS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471542#comment-16471542
]
genericqa commented on HDDS-39:
-------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 9 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m
3s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 26m
54s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 29m
6s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 4m
17s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
18m 33s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-project hadoop-ozone/integration-test {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
55s{color} | {color:red} hadoop-hdds/common in trunk has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
5s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
23s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
30s{color} | {color:red} common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
17s{color} | {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
15s{color} | {color:red} client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
14s{color} | {color:red} tools in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
16s{color} | {color:red} client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
16s{color} | {color:red} tools in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
16s{color} | {color:red} integration-test in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 27m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 27m
59s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 27m 59s{color}
| {color:red} root generated 11 new + 1477 unchanged - 0 fixed = 1488 total
(was 1477) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
9s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
32s{color} | {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
29s{color} | {color:red} client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
30s{color} | {color:red} tools in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
30s{color} | {color:red} client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
30s{color} | {color:red} tools in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
30s{color} | {color:red} integration-test in the patch failed. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 12s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-project hadoop-ozone/integration-test {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
29s{color} | {color:red} hadoop-hdds/common generated 18 new + 1 unchanged - 0
fixed = 19 total (was 1) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
31s{color} | {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
28s{color} | {color:red} client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
27s{color} | {color:red} tools in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
30s{color} | {color:red} client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
29s{color} | {color:red} tools in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
40s{color} | {color:red} hadoop-hdds_container-service generated 101 new + 1
unchanged - 0 fixed = 102 total (was 1) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
28s{color} | {color:red} hadoop-hdds_client generated 43 new + 0 unchanged - 0
fixed = 43 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
28s{color} | {color:red} hadoop-hdds_tools generated 2 new + 0 unchanged - 0
fixed = 2 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
30s{color} | {color:red} hadoop-ozone_client generated 4 new + 0 unchanged - 0
fixed = 4 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
29s{color} | {color:red} hadoop-ozone_tools generated 15 new + 0 unchanged - 0
fixed = 15 total (was 0) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
22s{color} | {color:green} hadoop-project in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
13s{color} | {color:green} common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 34s{color}
| {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 30s{color}
| {color:red} client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 29s{color}
| {color:red} tools in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 31s{color}
| {color:red} client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 31s{color}
| {color:red} tools in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 33s{color}
| {color:red} integration-test in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
45s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}151m 21s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdds/common |
| | Useless control flow in
org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos$CloseContainerRequestProto$Builder.maybeForceBuilderInitialization()
At ContainerProtos.java: At ContainerProtos.java:[line 17815] |
| | Useless control flow in
org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos$CloseContainerResponseProto$Builder.maybeForceBuilderInitialization()
At ContainerProtos.java: At ContainerProtos.java:[line 18363] |
| | Useless control flow in
org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos$CopyContainerRequestProto$Builder.maybeForceBuilderInitialization()
At ContainerProtos.java: At ContainerProtos.java:[line 34624] |
| | Useless control flow in
org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos$CopyContainerResponseProto$Builder.maybeForceBuilderInitialization()
At ContainerProtos.java: At ContainerProtos.java:[line 35479] |
| | Useless control flow in
org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos$CreateContainerResponseProto$Builder.maybeForceBuilderInitialization()
At ContainerProtos.java: At ContainerProtos.java:[line 12991] |
| | Useless control flow in
org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos$DatanodeBlockID$Builder.maybeForceBuilderInitialization()
At ContainerProtos.java: At ContainerProtos.java:[line 1112] |
| | Useless control flow in
org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos$DeleteChunkResponseProto$Builder.maybeForceBuilderInitialization()
At ContainerProtos.java: At ContainerProtos.java:[line 30029] |
| | Useless control flow in
org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos$DeleteContainerRequestProto$Builder.maybeForceBuilderInitialization()
At ContainerProtos.java: At ContainerProtos.java:[line 15580] |
| | Useless control flow in
org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos$DeleteContainerResponseProto$Builder.maybeForceBuilderInitialization()
At ContainerProtos.java: At ContainerProtos.java:[line 16042] |
| | Useless control flow in
org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos$DeleteKeyResponseProto$Builder.maybeForceBuilderInitialization()
At ContainerProtos.java: At ContainerProtos.java:[line 23085] |
| | Useless control flow in
org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos$KeyValue$Builder.maybeForceBuilderInitialization()
At ContainerProtos.java: At ContainerProtos.java:[line 1739] |
| | Useless control flow in
org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos$ListContainerRequestProto$Builder.maybeForceBuilderInitialization()
At ContainerProtos.java: At ContainerProtos.java:[line 16530] |
| | Useless control flow in
org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos$ListKeyRequestProto$Builder.maybeForceBuilderInitialization()
At ContainerProtos.java: At ContainerProtos.java:[line 23608] |
| | Useless control flow in
org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos$PutKeyResponseProto$Builder.maybeForceBuilderInitialization()
At ContainerProtos.java: At ContainerProtos.java:[line 20936] |
| | Useless control flow in
org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos$PutSmallFileResponseProto$Builder.maybeForceBuilderInitialization()
At ContainerProtos.java: At ContainerProtos.java:[line 32916] |
| | Useless control flow in
org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos$ReadContainerRequestProto$Builder.maybeForceBuilderInitialization()
At ContainerProtos.java: At ContainerProtos.java:[line 13417] |
| | Useless control flow in
org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos$UpdateContainerResponseProto$Builder.maybeForceBuilderInitialization()
At ContainerProtos.java: At ContainerProtos.java:[line 15107] |
| | Useless control flow in
org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos$WriteChunkResponseProto$Builder.maybeForceBuilderInitialization()
At ContainerProtos.java: At ContainerProtos.java:[line 27144] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDDS-39 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12922949/HDDS-39.003.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle xml cc |
| uname | Linux 1891ce237c7c 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 9db9cd9 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC1 |
| findbugs |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/branch-findbugs-hadoop-hdds_common-warnings.html
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-mvninstall-hadoop-hdds_common.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-mvninstall-hadoop-hdds_container-service.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-mvninstall-hadoop-hdds_client.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-mvninstall-hadoop-hdds_tools.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-mvninstall-hadoop-ozone_client.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-mvninstall-hadoop-ozone_tools.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/diff-compile-javac-root.txt
|
| mvnsite |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-mvnsite-hadoop-hdds_container-service.txt
|
| mvnsite |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-mvnsite-hadoop-hdds_client.txt
|
| mvnsite |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-mvnsite-hadoop-hdds_tools.txt
|
| mvnsite |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-mvnsite-hadoop-ozone_client.txt
|
| mvnsite |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-mvnsite-hadoop-ozone_tools.txt
|
| mvnsite |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-mvnsite-hadoop-ozone_integration-test.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/new-findbugs-hadoop-hdds_common.html
|
| findbugs |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-findbugs-hadoop-hdds_container-service.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-findbugs-hadoop-hdds_client.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-findbugs-hadoop-hdds_tools.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-findbugs-hadoop-ozone_client.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-findbugs-hadoop-ozone_tools.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/diff-javadoc-javadoc-hadoop-hdds_container-service.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/diff-javadoc-javadoc-hadoop-hdds_client.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/diff-javadoc-javadoc-hadoop-hdds_tools.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/diff-javadoc-javadoc-hadoop-ozone_client.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/diff-javadoc-javadoc-hadoop-ozone_tools.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-unit-hadoop-hdds_container-service.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-unit-hadoop-hdds_client.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-unit-hadoop-hdds_tools.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-unit-hadoop-ozone_client.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-unit-hadoop-ozone_tools.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/testReport/ |
| Max. process+thread count | 312 (vs. ulimit of 10000) |
| modules | C: hadoop-project hadoop-hdds/common hadoop-hdds/container-service
hadoop-hdds/client hadoop-hdds/tools hadoop-ozone/client hadoop-ozone/tools
hadoop-ozone/integration-test U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HDDS-Build/79/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Ozone: Compile Ozone/HDFS/Cblock protobuf files with proto3 compiler using
> maven protoc plugin
> ----------------------------------------------------------------------------------------------
>
> Key: HDDS-39
> URL: https://issues.apache.org/jira/browse/HDDS-39
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Native
> Affects Versions: 0.2.1
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-39.003.patch, HDFS-13389-HDFS-7240.001.patch,
> HDFS-13389-HDFS-7240.002.patch
>
>
> Currently all the Ozone/HDFS/Cblock proto files are compiled using proto 2.5,
> this can be changed to use proto3 compiler.
> This change will help in performance improvement as well because currently in
> the client path, the xceiver client ratis converts proto2 classes to proto3
> using byte string manipulation.
> Please note that for rest of hadoop (except Ozone/Cblock/HDSL), the protoc
> version will still remain 2.5 as this proto compilation will be done through
> the following plugin.
> https://www.xolstice.org/protobuf-maven-plugin/
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
