[ 
https://issues.apache.org/jira/browse/HDFS-13489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471654#comment-16471654
 ] 

Shashikant Banerjee commented on HDFS-13489:
--------------------------------------------

Thanks [~hpatro], for updating the patch. Some minor nitpicks on patch v6:

1.FSDirSnapshotOp.java:273 – Update the javadoc return tag

2.SnapshotManager.java: 184 – Update the javadoc return tag

3.FSNamesystem.java :  6645 - update the javadoc return tag

4.TestGetBaseDirSnapshottable:32 : Update the javadoc comment to specify the 
test functionality more appropriately.

i am +1 on the patch after that.

> Get base snapshotable path if exists for a given path
> -----------------------------------------------------
>
>                 Key: HDFS-13489
>                 URL: https://issues.apache.org/jira/browse/HDFS-13489
>             Project: Hadoop HDFS
>          Issue Type: Task
>          Components: hdfs
>            Reporter: Harkrishn Patro
>            Assignee: Harkrishn Patro
>            Priority: Major
>         Attachments: HDFS-13489.001.patch, HDFS-13489.002.patch, 
> HDFS-13489.003.patch, HDFS-13489.004.patch, HDFS-13489.005.patch, 
> HDFS-13489.006.patch, HDFS-13489.007.patch
>
>
> Currently, hdfs only lists the snapshotable paths in the filesystem. This 
> feature would add the functionality of figuring out if a given path is 
> snapshotable or not. If yes, it would return the base snapshotable path.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to