[ 
https://issues.apache.org/jira/browse/HDFS-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065480#comment-13065480
 ] 

Todd Lipcon commented on HDFS-2104:
-----------------------------------

Will make the following change:
{code}
@@ -737,7 +737,7 @@ public class SecondaryNameNode implements Runnable {
     try {
       opts.parse(argv);
     } catch (ParseException pe) {
-      LOG.warn(pe);
+      LOG.error(pe.getMessage());
       opts.usage();
       return null;
     }
{code}

Manual testing of this change shows:
{noformat}

todd@todd-w510:~/git/hadoop-common/hdfs$ ./bin/hdfs  secondarynamenode -fdsa
11/07/14 12:18:46 ERROR namenode.SecondaryNameNode: Unrecognized option: -fdsa
usage: secondarynamenode
 -checkpoint <force>   checkpoint on startup
 -format               format the local storage during startup
 -geteditsize          return the number of uncheckpointed transactions on
                       the NameNode
{noformat}

Since this is a trivial difference from the first patch I'll commit with this 
fix in place.

> 1073: Add a flag to 2NN to format its checkpoint dirs on startup
> ----------------------------------------------------------------
>
>                 Key: HDFS-2104
>                 URL: https://issues.apache.org/jira/browse/HDFS-2104
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Todd Lipcon
>         Attachments: hdfs-2104.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to