[
https://issues.apache.org/jira/browse/HDDS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478650#comment-16478650
]
Mukul Kumar Singh commented on HDDS-76:
---------------------------------------
Thanks for the patch [~shashikant]. The patch looks really good to me. Please
find my comments as following.
1) ContainerLocationManager.java: 131, we can remove the TODO now I think :)
2) ScmContainerDatanodeProtocol.proto:152, we should add a field to signify
that storage report has failed.
3) StorageLocationReport.java:22, unused import
4) I was also thinking if a toProtobuf and getFromProtobuf functions should be
added in StorageLocationReport.java.
> Modify SCMStorageReportProto to include the data dir paths as well as the
> StorageType info
> ------------------------------------------------------------------------------------------
>
> Key: HDDS-76
> URL: https://issues.apache.org/jira/browse/HDDS-76
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Attachments: HDDS-76.00.patch
>
>
> Currently, SCMStorageReport contains the storageUUID which are sent across to
> SCM for maintaining storage Report info. This Jira aims to include the data
> dir paths for actual disks as well as the storage Type info for each volume
> on datanode to be sent to SCM.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
