[
https://issues.apache.org/jira/browse/HDFS-13592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480863#comment-16480863
]
Giovanni Matteo Fumarola commented on HDFS-13592:
-------------------------------------------------
Thanks [~huanbang1993] for working on this.
LGTM +1.
However, most of the unit tests that failed in Windows had the missing close
clause. We should write a comment in \{{MiniDFSCluster}} to make sure the new
unit tests follow the rule of closing the object.
> TestNameNodePrunesMissingStorages#testNameNodePrunesUnreportedStorages does
> not shut down cluster properly
> ----------------------------------------------------------------------------------------------------------
>
> Key: HDFS-13592
> URL: https://issues.apache.org/jira/browse/HDFS-13592
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Anbang Hu
> Assignee: Anbang Hu
> Priority: Minor
> Labels: Windows
> Attachments: HDFS-13592.000.patch
>
>
> Without cluster shutdown in
> TestNameNodePrunesMissingStorages#testNameNodePrunesUnreportedStorages, the
> below two tests fail (referring to
> https://builds.apache.org/job/hadoop-trunk-win/469/testReport/)
> *
> [TestNameNodePrunesMissingStorages#testUnusedStorageIsPruned|https://builds.apache.org/job/hadoop-trunk-win/469/testReport/org.apache.hadoop.hdfs.server.blockmanagement/TestNameNodePrunesMissingStorages/testUnusedStorageIsPruned/]
> *
> [TestNameNodePrunesMissingStorages#testRemovingStorageDoesNotProduceZombies|https://builds.apache.org/job/hadoop-trunk-win/469/testReport/org.apache.hadoop.hdfs.server.blockmanagement/TestNameNodePrunesMissingStorages/testRemovingStorageDoesNotProduceZombies/]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
