[ 
https://issues.apache.org/jira/browse/HDFS-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066101#comment-13066101
 ] 

Uma Maheswara Rao G commented on HDFS-2154:
-------------------------------------------

{quote}
 2. To form testdir, could you please use the two-argument constructor of 
java.io.File, rather than string concatenation?
{quote}
  Here testdir is used to create Path object, not java.io.File :-(. Also 
testdir used in many places in down the line.
To get the absolute path from Path again, we may need to use toString on Path. 
I feel two string concatenation is better than toString construction on Path.



> TestDFSShell should use test dir
> --------------------------------
>
>                 Key: HDFS-2154
>                 URL: https://issues.apache.org/jira/browse/HDFS-2154
>             Project: Hadoop HDFS
>          Issue Type: Test
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: h2154_20110715.patch
>
>
> The new test by HDFS-2131 creates files/directories under currently directory.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to