[ https://issues.apache.org/jira/browse/HDFS-13344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482558#comment-16482558 ]
genericqa commented on HDFS-13344: ---------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 29s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 25m 54s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 22s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 15s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 23s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 10m 45s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 28s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 11s{color} | {color:orange} hadoop-tools/hadoop-azure-datalake: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 35s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 46s{color} | {color:green} hadoop-azure-datalake in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 24s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 54m 10s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd | | JIRA Issue | HDFS-13344 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12924344/HDFS-13344-001.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 968dc02bf028 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / c97df77 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_162 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/24268/artifact/out/diff-checkstyle-hadoop-tools_hadoop-azure-datalake.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/24268/testReport/ | | Max. process+thread count | 333 (vs. ulimit of 10000) | | modules | C: hadoop-tools/hadoop-azure-datalake U: hadoop-tools/hadoop-azure-datalake | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/24268/console | | Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > adl.AdlFilesystem.close() doesn't release locks on open files > ------------------------------------------------------------- > > Key: HDFS-13344 > URL: https://issues.apache.org/jira/browse/HDFS-13344 > Project: Hadoop HDFS > Issue Type: Bug > Components: fs/adl > Affects Versions: 2.7.3 > Environment: HDInsight on MS Azure: > > Hadoop 2.7.3.2.6.2.25-1 > Subversion g...@github.com:hortonworks/hadoop.git -r > 1ceeb58bb3bb5904df0cbb7983389bcaf2ffd0b6 > Compiled by jenkins on 2017-11-29T15:28Z > Compiled with protoc 2.5.0 > From source with checksum 90b73c4c185645c1f47b61f942230 > This command was run using > /usr/hdp/2.6.2.25-1/hadoop/hadoop-common-2.7.3.2.6.2.25-1.jar > Reporter: Jay Hankinson > Assignee: Vishwajeet Dusane > Priority: Major > Attachments: HDFS-13344-001.patch > > > If you write to a file on and Azure ADL filesystem and close the file system > but not the file before the process exits, the next time you try open the > file for append it fails with: > Exception in thread "main" java.io.IOException: APPEND failed with error > 0x83090a16 (Failed to perform the requested operation because the file is > currently open in write mode by another user or process.). > [a67c6b32-e78b-4852-9fac-142a3e2ba963][2018-03-22T20:54:08.3520940-07:00] > The following moves local file to HDFS if it doesn't exist or appends it's > contents if it does: > > {code:java} > public void addFile(String source, String dest, Configuration conf) throws > IOException { > FileSystem fileSystem = FileSystem.get(conf); > // Get the filename out of the file path > String filename = source.substring(source.lastIndexOf('/') + > 1,source.length()); > // Create the destination path including the filename. > if (dest.charAt(dest.length() - 1) != '/') > { dest = dest + "/" + filename; } > else { > dest = dest + filename; > } > // Check if the file already exists > Path path = new Path(dest); > FSDataOutputStream out; > if (fileSystem.exists(path)) { > System.out.println("File " + dest + " already exists appending"); > out = fileSystem.append(path); > } else { > out = fileSystem.create(path); > } > // Create a new file and write data to it. > InputStream in = new BufferedInputStream(new FileInputStream(new File( > source))); > byte[] b = new byte[1024]; > int numBytes = 0; > while ((numBytes = in.read(b)) > 0) { > out.write(b, 0, numBytes); > } > // Close the file system not the file > in.close(); > //out.close(); > fileSystem.close(); > } > {code} > If "dest" is an adl:// location, invoking the function a second time (after > the process has exited) it raises the error. If it's a regular hdfs:// file > system, it doesn't as all the locks are released. The same exception is also > raised if a subsequent append is done using: hdfs dfs -appendToFile. > As I can't see a way to force lease recovery in this situation, this seems > like a bug. org.apache.hadoop.fs.adl.AdlFileSystem inherits close() from > org.apache.hadoop.fs.FileSystem > [https://hadoop.apache.org/docs/r3.0.0/api/org/apache/hadoop/fs/adl/AdlFileSystem.html] > Which states: > Close this FileSystem instance. Will release any held locks. This does not > seem to be the case -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org