[
https://issues.apache.org/jira/browse/HDDS-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482740#comment-16482740
]
Xiaoyu Yao commented on HDDS-79:
--------------------------------
[~nandakumar131], thanks for working on this. The patch looks good to me
overall. Just few minor issue:
The patch needs to be rebased on trunk.
ContainerReportManager.java and ContainerReportManagerImpl can be removed.
(The randomization logic should stay in the datanode side with the push model)
ContainerManagerImpl.java
Line 129/203-204: this can be removed since it is only used by the pull model
ContainerReportHandler.java
Lien 66: I think we should have randomization logic around here so that DN
won't send container report simultaneously to SCM
TestNodeManager.java
Line 28: unused import
> Remove ReportState from SCMHeartbeatRequestProto
> ------------------------------------------------
>
> Key: HDDS-79
> URL: https://issues.apache.org/jira/browse/HDDS-79
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Datanode, SCM
> Reporter: Nanda kumar
> Assignee: Nanda kumar
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-79.000.patch
>
>
> Since datanode will be sending container report in the configured interval
> there is no need to send {{ReportState}} in heartbeat. {{ReportState}} is
> only useful in pull model implementation of container report, this change can
> be reverted in future if we also want to support pull model.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
