[
https://issues.apache.org/jira/browse/HDDS-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482872#comment-16482872
]
Xiaoyu Yao edited comment on HDDS-82 at 5/21/18 6:32 PM:
---------------------------------------------------------
Thanks [~bharatviswa] for working on this. The patch v2 looks good to me
overall. I just have few minor comments:
ContainerManagerImpl.java
Line 245/286: If we change here to allow putting null into containerMap, we
will need to add null check in many places when containerMap.get() is called
such as Line 835/930/941,etc. to avoid NPE. I would suggest we follow the
existing pattern by putting a "new ContainerData(containerID, conf)" with an
INVALID state (HDDS-85 will add this to protobuf def);
Line 462: here we need to check the containerData.state == INVALID
was (Author: xyao):
Thanks [~bharatviswa] for working on this. The patch v2 looks good to me
overall. I just have few minor comments:
ContainerManagerImpl.java
Line 245/286: If we change here to allow putting null into containerMap, we
will need to add null check in many places when containerMap.get() is called
such as Line 835/930/941,etc. to avoid NPE. I would suggest we follow the
existing pattern by putting a "new ContainerData(containerID, conf)" with an
INVALID state;
Line 462: here we need to check the containerData.state == INVALID
> Merge ContainerData and ContainerStatus classes
> -----------------------------------------------
>
> Key: HDDS-82
> URL: https://issues.apache.org/jira/browse/HDDS-82
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-82.001.patch, HDDS-82.002.patch
>
>
> According to refactoring of containerIO, ContainerData has common fields for
> different kinds of containerTypes, and each Container will extend
> ConatinerData to add its fields. So, for this merging ContainerStatus fields
> to ConatinerData.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
