[
https://issues.apache.org/jira/browse/HDFS-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066156#comment-13066156
]
Uma Maheswara Rao G commented on HDFS-2116:
-------------------------------------------
1. What is the purpose of this assertion?
{code}
assertNull("Seek to 101 should not result in another request", null);
{code}
2.looks your coding formatter is not correct. Hadoop intendation is two spaces.
3.Patch contains hard core tabs, can you pleasse remove them?
4.{code}
} catch (Exception e) {
+ System.out.println(e.getMessage());
+ }
{code}
dont catch the generic exceptions.
5. when i try to apply patch, looks there are some conflicts with the trunk.
can you please update properly?
perhaps you can try applying the parch.
6.what about TestStreamFile cleanup?
> Cleanup TestStreamFile and TestByteRangeInputStream
> ----------------------------------------------------
>
> Key: HDFS-2116
> URL: https://issues.apache.org/jira/browse/HDFS-2116
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Reporter: Eli Collins
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-2116.patch
>
>
> TestStreamFile and TestByteRangeInputStream should use mockito. This would
> allow the private URLOpener class to be removed from ByteRangeInputStream.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
