[
https://issues.apache.org/jira/browse/HDDS-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483909#comment-16483909
]
Nanda kumar commented on HDDS-79:
---------------------------------
Thanks [~xyao] for the review, I have rebased the patch on top of latest trunk
changes.
bq. The randomization logic should stay in the datanode side with the push
model...
ContainerReportManager and ContainerReportManagerImpl are already in
{{container-service}} project (which is datanode code of hdds), the reason for
not removing these classes is for later reuse.
bq. Line 129/203-204: this can be removed since it is only used by the pull
model
Now the {{ContainerReportManager}} has been modified to check if we have to
send ContainerReport, this will be useful in push model. I know this is not
actually used anywhere in the code as of now, but this will be used in later
patches.
bq. ContainerReportHandler.java
{{ContainerReportHandler}} is for handling SCM's {{SendContainerCommand}}, we
are removing both {{SendContainerCommand}} and {{ContainerReportHandler}} as
part of HDDS-80.
bq. I think we should have randomization logic
Yup, true. Randomization logic will be added in the follow-up jiras under
HDDS-22
> Remove ReportState from SCMHeartbeatRequestProto
> ------------------------------------------------
>
> Key: HDDS-79
> URL: https://issues.apache.org/jira/browse/HDDS-79
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Datanode, SCM
> Reporter: Nanda kumar
> Assignee: Nanda kumar
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-79.000.patch, HDDS-79.001.patch
>
>
> Since datanode will be sending container report in the configured interval
> there is no need to send {{ReportState}} in heartbeat. {{ReportState}} is
> only useful in pull model implementation of container report, this change can
> be reverted in future if we also want to support pull model.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
