[ 
https://issues.apache.org/jira/browse/HDFS-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066249#comment-13066249
 ] 

Aaron T. Myers commented on HDFS-2141:
--------------------------------------

+1, this patch looks good to me. If you care to, you might want to line up the 
indentation of ("NameNode") with the other members of {{NameNodeRole}}, but no 
reason to make another patch for it.

We might even consider merging {{HdfsConstants.NodeType}} and 
{{HdfsConstants.NameNodeRole}}, since being a DN is certainly mutually 
exclusive with all of the {{NameNodeRoles}}, but that should probably be done 
as a separate JIRA.

> Remove NameNode roles Active and Standby
> ----------------------------------------
>
>                 Key: HDFS-2141
>                 URL: https://issues.apache.org/jira/browse/HDFS-2141
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>         Attachments: HDFS-2141.patch
>
>
> In HDFS, following roles are supported in NameNodeRole: ACTIVE, BACKUP, 
> CHECKPOINT and STANDBY.
> Active and Standby are the state of the NameNode. While Backup and CheckPoint 
> are the name/role of the daemons that are started. This mixes up the run time 
> state of NameNode with the daemon role. I propose changing the NameNodeRole 
> to: NAMENODE, BACKUP, CHECKPOINT. HDFS-1974 will introduce the states active 
> and standby to the daemon that is running in the role NAMENODE.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to