[
https://issues.apache.org/jira/browse/HDDS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16486815#comment-16486815
]
Mukul Kumar Singh commented on HDDS-45:
---------------------------------------
Thanks for the v3 patch [~ljain]. Please find my comments as following.
1) TestKeys.java:37 - wildcards in imports
2) TestKeysRatis.java:25 - Unused import
3) TestVolume.java:37 - wildcards in imports
4) TestVolume.java:4 - Unused imports
5) XceiverClientGrpc has been added as a new standalone protocol for
communication between client and datanode. I feel a reconnect method should be
added to this class as well, this can be done as part of a followup jira as
well.
6) Lets also create another jira to make the test classes parameterized with
support for RestClient as well.
> Removal of old OzoneRestClient
> ------------------------------
>
> Key: HDDS-45
> URL: https://issues.apache.org/jira/browse/HDDS-45
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Client
> Reporter: Nanda kumar
> Assignee: Lokesh Jain
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-45.001.patch, HDDS-45.002.patch, HDDS-45.003.patch
>
>
> Originally, Ozone used to have a REST client only, that is what was used in
> the oz CLI. Later we developed an RPC client and started using it Freon. The
> load generator for Ozone. Then we created a common interface and created
> factory methods for RestClient or RpcClient. That allows CLI or Freon or any
> program that is using the Ozone client SDK to trivially switch between REST
> and RPC.
> This patch removes the old REST client from the code base, since the new code
> has better features and all the clients (CLI, Freon, Tests) have switched to
> using this new client with this patch.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
