[
https://issues.apache.org/jira/browse/HDFS-13578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494034#comment-16494034
]
Erik Krogen commented on HDFS-13578:
------------------------------------
I think we are unnecessarily confusing {{OperationCategory}} with what we are
trying to achieve here. {{refreshNodes}} and {{finalizeUpgrade}} are most
certainly *not* read-only, as they both modify the state of the service. I
think the important point is that the assertion "UNCHECKED and thus readonly"
is not true; UNCHECKED does not imply read only. The {{@ReadOnly}} annotation
indicates that an operation is only reading, not mutating, so the proxy
provider has the ability to reroute the request as it wishes without affecting
behavior.
> Add ReadOnly annotation to methods in ClientProtocol
> ----------------------------------------------------
>
> Key: HDFS-13578
> URL: https://issues.apache.org/jira/browse/HDFS-13578
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chao Sun
> Assignee: Chao Sun
> Priority: Major
> Attachments: HDFS-13578-HDFS-12943.000.patch,
> HDFS-13578-HDFS-12943.001.patch, HDFS-13578-HDFS-12943.002.patch,
> HDFS-13578-HDFS-12943.004.patch
>
>
> For those read-only methods in {{ClientProtocol}}, we may want to use a
> {{@ReadOnly}} annotation to mark them, and then check in the proxy provider
> for observer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
