[ 
https://issues.apache.org/jira/browse/HDFS-13632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494591#comment-16494591
 ] 

Íñigo Goiri commented on HDFS-13632:
------------------------------------

Let's make {{MiniQJMHACluster}} consistent with {{MiniJournalCluster}}:
{code}
public Builder baseDir(String d) {
  this.baseDir = d;
  return this;
}
{code}
And no need for {{private String baseDir = 
MiniDFSCluster.getBaseDirectory();}}, we can just pass null and 
{{MiniJournalCluster}} should take care of this.

> Randomize baseDir for MiniJournalCluster in MiniQJMHACluster for 
> TestDFSAdminWithHA 
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-13632
>                 URL: https://issues.apache.org/jira/browse/HDFS-13632
>             Project: Hadoop HDFS
>          Issue Type: Test
>            Reporter: Anbang Hu
>            Assignee: Anbang Hu
>            Priority: Minor
>         Attachments: HDFS-13632-branch-2.000.patch, 
> HDFS-13632-branch-2.001.patch, HDFS-13632.000.patch, HDFS-13632.001.patch, 
> HDFS-13632.002.patch, HDFS-13632.003.patch
>
>
> As [HDFS-13630|https://issues.apache.org/jira/browse/HDFS-13630] indicates, 
> testUpgradeCommand keeps journalnode directory from being released, which 
> fails all subsequent tests that try to use the same path.
> Randomizing the baseDir for MiniJournalCluster in MiniQJMHACluster for 
> TestDFSAdminWithHA can isolate effects of tests from each other.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to