[
https://issues.apache.org/jira/browse/HDDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495321#comment-16495321
]
Anu Engineer commented on HDDS-116:
-----------------------------------
I am +1 on this change, Have one minor comment.
# VolumeSet.java#initializeVolumeSet - Can we please introduce an
HDDS_DATANODE_DIR_KEY. THis allows us to have HDDS to map to disks which are
not used by HDFS if needed, that is we can stop assuming that the DATA_DIR are
exactly same, if that value is not defined, let us assume
DFS_DATANODE_DATA_DIR_KEY, is the key.
# VolumeSet.java#nit: move code from Line:87 to 93 into a function and reuse
later.
# VolumeSet#Since we don't use this anywhere, it might be may not matter for
now, but just for curiosities sake – what happens if VolumeSet throws ?
> Implement VolumeSet to manage disk volumes
> ------------------------------------------
>
> Key: HDDS-116
> URL: https://issues.apache.org/jira/browse/HDDS-116
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Labels: ContainerIO
> Fix For: 0.2.1
>
> Attachments: HDDS-116-HDDS-48.001.patch, HDDS-116-HDDS-48.002.patch,
> HDDS-116-HDDS-48.003.patch
>
>
> VolumeSet would be responsible for managing volumes in the Datanode. Some of
> its functions are:
> # Initialize volumes on startup
> # Provide APIs to add/ remove volumes
> # Choose and return volume to calling service based on the volume choosingÂ
> policy (currently implemented Round Robin choosing policy)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
