[ 
https://issues.apache.org/jira/browse/HDDS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495814#comment-16495814
 ] 

Bharat Viswanadham edited comment on HDDS-97 at 5/30/18 10:36 PM:
------------------------------------------------------------------

Hi [~xyao]

Thanks for the review.

Addressed review comments in the latest patch.

VolumeSet integration is not done in this patch when we integrate Volume 
classes, this part of the code will use new Volume classes.

 
{quote}DatanodeVersionFile.java

Line 43: should we include a cluster ID as well?  ** 
{quote}
 

As we store scmUuid, clusterID will not be required. As from the scmUuid, we 
can know the information that this datanode belongs to particular SCM server. 
Please provide inputs, if it needs to be added for any other reason.

 


was (Author: bharatviswa):
Hi [~xyao]

Thanks for the review.

Addressed review comments in the latest patch.

VolumeSet integration is not done in this patch when we integrate Volume 
classes, this part of the code will use new Volume classes.

 
{quote}DatanodeVersionFile.java

Line 43: should we include a cluster ID as well?  ** 
{quote}
 

As we store scmUuid, clusterID will not be required. As from the scmUuid, we 
can know the information that this datanode belongs to particular SCM server. 
Let me know if it needs to be added for any other reason.

 

> Create Version File in Datanode
> -------------------------------
>
>                 Key: HDDS-97
>                 URL: https://issues.apache.org/jira/browse/HDDS-97
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-97-HDDS-48.00.patch, HDDS-97-HDDS-48.01.patch, 
> HDDS-97-HDDS-48.02.patch, HDDS-97-HDDS-48.03.patch, HDDS-97-HDDS-48.04.patch
>
>
> Create a versionFile in dfs.datanode.dir/hdds/ path.
> The content of the versionFile:
>  # scmUuid
>  # CTime
>  # layOutVersion
> When datanodes makes a request for SCMVersion, in this response we send 
> scmUuid.
> With this response, we should be able to create version file on the datanode.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to